Skip to content

Fix Resource Monitoring sample app #47058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
evgenyfedorov2 merged 2 commits into from
Jul 8, 2025
Merged

Fix Resource Monitoring sample app #47058

evgenyfedorov2 merged 2 commits into from
Jul 8, 2025

Conversation

@evgenyfedorov2
Copy link
Member

@evgenyfedorov2 evgenyfedorov2 commented Jul 2, 2025 •
edited
Loading

Summary

As mentioned here, the sample app outputs incorrect values over and over again.

The change fixes the sample by adding Host, which is necessary for the underlying BackgroundService in Resource Monitoring.

Internal previews

📄 File 🔗 Preview link
docs/core/diagnostics/diagnostic-resource-monitoring.md Resource monitoring

@evgenyfedorov2 evgenyfedorov2 requested review from a team and tommcdon as code owners July 2, 2025 08:55
@dotnetrepoman dotnetrepoman bot added this to the July 2025 milestone Jul 2, 2025
@evgenyfedorov2 evgenyfedorov2 force-pushed the users/evgenyfedorov2/fix_rm_sample branch from 21d06f5 to 406fcfa Compare July 2, 2025 09:06
@evgenyfedorov2 evgenyfedorov2 enabled auto-merge (squash) July 2, 2025 09:14
@evgenyfedorov2 evgenyfedorov2 mentioned this pull request Jul 2, 2025
Closed
@kkostrzewa-coupa
Copy link

kkostrzewa-coupa commented Jul 2, 2025

With this change, ctrl+c cancelation no longer works. I think the Console.CancelKeyPress event handler needs to be placed before the await AnsiConsole.Live(table)..., or else we get an infinite loop.

@evgenyfedorov2
Copy link
Member Author

evgenyfedorov2 commented Jul 3, 2025

With this change, ctrl+c cancelation no longer works. I think the Console.CancelKeyPress event handler needs to be placed before the await AnsiConsole.Live(table)..., or else we get an infinite loop.

Updated, thank you!

@evgenyfedorov2
Copy link
Member Author

evgenyfedorov2 commented Jul 3, 2025

@IEvangelist whenever you have time, could you please review this?

@evgenyfedorov2 evgenyfedorov2 requested a review from gewarren July 7, 2025 07:21
@evgenyfedorov2 evgenyfedorov2 merged commit 448d271 into dotnet:main Jul 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IEvangelist IEvangelist IEvangelist approved these changes

@tommcdon tommcdon Awaiting requested review from tommcdon tommcdon is a code owner

@gewarren gewarren Awaiting requested review from gewarren

Assignees

No one assigned

Labels

dotnet-fundamentals/svc

Projects

None yet

Milestone

July 2025

Development

Successfully merging this pull request may close these issues.

3 participants

@evgenyfedorov2 @kkostrzewa-coupa @IEvangelist